Closed forus closed 2 months ago
Lastly just try to address as much as the sonar cloud issues as possible
Lastly just try to address as much as the sonar cloud issues as possible
@haynescd please have another look. The last 2 sonar cloud issues are intended. There is ticket for fixing those https://github.com/cBioPortal/cbioportal/issues/10843
@haynescd Please have a look into docs https://github.com/cBioPortal/cbioportal/pull/10829/commits/3ca2a7b453c3cdc5400a031fa7dc4ea0ff8fa303
@pieterlukasse Please check these extras https://github.com/cBioPortal/cbioportal/pull/10829/commits/162e5a4aa01dcd89ef1bcb4096989689a4b9c088
Looks good. One final question: what guarantees that test5UnpublishVirtualStudy, test6NoPublicVirtualStudiesAfterRemoval, test7UnpublishedVirtualStudyExists execute in sequence?
Looks good. One final question: what guarantees that test5UnpublishVirtualStudy, test6NoPublicVirtualStudiesAfterRemoval, test7UnpublishedVirtualStudyExists execute in sequence?
@FixMethodOrder(MethodSorters.NAME_ASCENDING)
at the top of the test class.
Issues
3 New issues
0 Accepted issues
Measures
0 Security Hotspots
74.4% Coverage on New Code
0.0% Duplication on New Code
Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
Frontend https://github.com/cBioPortal/cbioportal-frontend/pull/4923
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging policy. It can help to figure out who worked on the file before you. Please use
git blame <filename>
to determine that and notify them either through slack or by assigning them as a reviewer on the PR