search

cBioPortal / cbioportal

cBioPortal for Cancer Genomics
https://cbioportal.org
GNU Affero General Public License v3.0
628 stars 480 forks source link

Refactor SessionServiceController to reuse some of the SessionServiceRequestHandler methods. #10876

Open forus opened 3 months ago

forus commented 3 months ago

Proposed here: https://github.com/cBioPortal/cbioportal/pull/10829#discussion_r1662354069

SessionServiceRequestHandler is an HTTP client that talks to the session service. It has all low-level HTTP code to interact with the session service. SessionServiceController is doing the same now.

We can make SessionServiceController to call SessionServiceRequestHandler instead of composing low-level HTTP calls by itself. See PublicVirtualStudiesController as an example

Mehdi-17 commented 3 months ago

Hello @forus , can I work on this issue if no one else is?

forus commented 3 months ago

Hello @forus , can I work on this issue if no one else is?

@Mehdi-17 Hello, sure. Please go ahead. Thank you!

Mehdi-17 commented 3 months ago

@forus thank you !!

darkhanzhursin commented 1 month ago

Hi @forus @Mehdi-17 what is the status of this issue?