cBioPortal / cbioportal

cBioPortal for Cancer Genomics
https://cbioportal.org
GNU Affero General Public License v3.0
664 stars 530 forks source link

Kaplan-Meir plots are very slow to render in study view when sample count is large #11019

Open alisman opened 2 months ago

alisman commented 2 months ago

@inodb @dippindots i'm still convinced that we should just be aggressively sampling here, that in the context of the study view it's the general curve and that user doesn't need to able to mousover and find individusal samples?

https://genie-public-beta.cbioportal.org/study/summary?id=brca_akt1_genie_2019%2Claml_tcga_pan_can_atlas_2018%2Cacc_tcga_pan_can_atlas_2018%2Cblca_tcga_pan_can_atlas_2018%2Clgg_tcga_pan_can_atlas_2018%2Cbrca_tcga_pan_can_atlas_2018%2Ccesc_tcga_pan_can_atlas_2018%2Cchol_tcga_pan_can_atlas_2018%2Ccoadread_tcga_pan_can_atlas_2018%2Cglioma_dfci_2020%2Cdlbc_tcga_pan_can_atlas_2018%2Cerbb2_genie_public%2Cesca_tcga_pan_can_atlas_2018%2Ccrc_public_genie_bpc%2Cnsclc_public_genie_bpc%2Cgenie_public%2Cgbm_tcga_pan_can_atlas_2018%2Chnsc_tcga_pan_can_atlas_2018%2Ckich_tcga_pan_can_atlas_2018%2Ckirc_tcga_pan_can_atlas_2018%2Ckirp_tcga_pan_can_atlas_2018%2Clihc_tcga_pan_can_atlas_2018%2Cluad_tcga_pan_can_atlas_2018%2Clusc_tcga_pan_can_atlas_2018%2Cmeso_tcga_pan_can_atlas_2018%2Cmbc_genie_2020%2Cov_tcga_pan_can_atlas_2018%2Cpaad_tcga_pan_can_atlas_2018%2Cpcpg_tcga_pan_can_atlas_2018%2Cprad_tcga_pan_can_atlas_2018%2Csarc_tcga_pan_can_atlas_2018%2Cskcm_tcga_pan_can_atlas_2018%2Cstad_tcga_pan_can_atlas_2018%2Ctgct_tcga_pan_can_atlas_2018%2Cthym_tcga_pan_can_atlas_2018%2Cthca_tcga_pan_can_atlas_2018%2Cucs_tcga_pan_can_atlas_2018%2Cucec_tcga_pan_can_atlas_2018%2Cuvm_tcga_pan_can_atlas_2018

inodb commented 2 months ago

@alisman yea that makes sense to me - can def sample more aggressively. Seems like we are only applying sampling to OS, but not DFS, PFS, etc:

image image