cBioPortal / cbioportal

cBioPortal for Cancer Genomics
https://cbioportal.org
GNU Affero General Public License v3.0
658 stars 519 forks source link

Genomic data counts returns results in CH under filtering when legacy does not #11023

Closed alisman closed 1 month ago

alisman commented 1 month ago
fetch("http://localhost:8082/api/clinical-data-counts/fetch?", {
  "headers": {
    "accept": "*/*",
    "accept-language": "en-US,en;q=0.9",
    "cache-control": "no-cache",
    "content-type": "application/json",
    "pragma": "no-cache",
    "sec-ch-ua": "\"Chromium\";v=\"128\", \"Not;A=Brand\";v=\"24\", \"Google Chrome\";v=\"128\"",
    "sec-ch-ua-mobile": "?0",
    "sec-ch-ua-platform": "\"macOS\"",
    "sec-fetch-dest": "empty",
    "sec-fetch-mode": "cors",
    "sec-fetch-site": "same-origin",
    "x-requested-with": "XMLHttpRequest"
  },
  "referrer": "http://localhost:8082/study/summary?id=brca_tcga_pan_can_atlas_2018%2Cbrca_akt1_genie_2019",
  "referrerPolicy": "strict-origin-when-cross-origin",
  "body": "{\"attributes\":[{\"attributeId\":\"OS_STATUS\"},{\"attributeId\":\"DFS_STATUS\"},{\"attributeId\":\"DSS_STATUS\"},{\"attributeId\":\"PFS_STATUS\"},{\"attributeId\":\"SUBTYPE\"},{\"attributeId\":\"TUMOR_TYPE\"},{\"attributeId\":\"SEX\"},{\"attributeId\":\"ETHNICITY\"},{\"attributeId\":\"AKT_MUTATION_STATUS\"},{\"attributeId\":\"SAMPLE_TYPE\"},{\"attributeId\":\"RACE\"},{\"attributeId\":\"CANCER_TYPE_DETAILED\"},{\"attributeId\":\"AKT_INHIBITOR_YN\"},{\"attributeId\":\"AJCC_STAGE\"},{\"attributeId\":\"ADDITIONAL_SEQUENCING\"}],\"studyViewFilter\":{\"genomicDataFilters\":[{\"hugoGeneSymbol\":\"EGFR\",\"profileType\":\"cna\",\"values\":[{\"value\":\"NA\"}]},{\"hugoGeneSymbol\":\"EGFR\",\"profileType\":\"rppa\",\"values\":[{\"start\":-0.3,\"end\":-0.2},{\"start\":-0.2,\"end\":-0.1}]}],\"studyIds\":[\"brca_tcga_pan_can_atlas_2018\",\"brca_akt1_genie_2019\"],\"alterationFilter\":{\"copyNumberAlterationEventTypes\":{\"AMP\":true,\"HOMDEL\":true},\"mutationEventTypes\":{\"any\":true},\"structuralVariants\":null,\"includeDriver\":true,\"includeVUS\":true,\"includeUnknownOncogenicity\":true,\"includeUnknownTier\":true,\"includeGermline\":true,\"includeSomatic\":true,\"includeUnknownStatus\":true,\"tiersBooleanMap\":{}}}}",
  "method": "POST",
  "mode": "cors",
  "credentials": "include"
});

http://localhost:8082/study/summary?id=brca_tcga_pan_can_atlas_2018%2Cbrca_akt1_genie_2019

image
alisman commented 1 month ago

CH is return an item for NA when NA count is 0.

alisman commented 1 month ago

Legacy is returning the WRONG result. There are only samples EGFR-CNA=NA (195) so if you filter for those NAs, the result shouldn't change. But in fact, the legacy returns no results. It is not properly recognizing NA. Whereas CH implementation IS