cBioPortal / cbioportal

cBioPortal for Cancer Genomics
https://cbioportal.org
GNU Affero General Public License v3.0
661 stars 525 forks source link

Remaining NA issue with generic-assay-bin-counts (Methylation) #11033

Closed alisman closed 1 month ago

alisman commented 1 month ago

NA counts are missing from results here (not in legacy)

curl 'http://localhost:8082/api/column-store/generic-assay-data-bin-counts/fetch?dataBinMethod=STATIC' \
  -H 'Accept: application/json' \
  -H 'Accept-Language: en-US,en;q=0.9' \
  -H 'Cache-Control: no-cache' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: application/json' \
  -H 'Cookie: _ga=GA1.1.1887007066.1710956751; _ga_5260NDGD6Z=GS1.1.1721930557.11.1.1721930574.0.0.0' \
  -H 'Origin: http://localhost:8082' \
  -H 'Pragma: no-cache' \
  -H 'Referer: http://localhost:8082/study/summary?id=stad_tcga_pan_can_atlas_2018' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36' \
  -H 'sec-ch-ua: "Chromium";v="128", "Not;A=Brand";v="24", "Google Chrome";v="128"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  --data-raw '{"genericAssayDataBinFilters":[{"stableId":"cg00008713","profileType":"methylation_hm27_hm450_merge","disableLogScale":false}],"studyViewFilter":{"studyIds":["stad_tcga_pan_can_atlas_2018"],"alterationFilter":{"copyNumberAlterationEventTypes":{"AMP":true,"HOMDEL":true},"mutationEventTypes":{"any":true},"structuralVariants":null,"includeDriver":true,"includeVUS":true,"includeUnknownOncogenicity":true,"includeUnknownTier":true,"includeGermline":true,"includeSomatic":true,"includeUnknownStatus":true,"tiersBooleanMap":{}}}}'
fuzhaoyuan commented 1 month ago
image

So with my SQL query it does return 'NA' object with count = 0. The problem should be in the code binner part. Will look into that

fuzhaoyuan commented 1 month ago

@alisman should we display NA = 0 when there is no NA?

alisman commented 1 month ago

@fuzhaoyuan showed that it's the legacy which returns NA=0. It should not do that. We can disregard this ticket.

fuzhaoyuan commented 1 month ago

Should we address this in the legacy portal sometime in the future? Maybe a new ticket?