cBioPortal / cbioportal

cBioPortal for Cancer Genomics
https://cbioportal.org
GNU Affero General Public License v3.0
641 stars 497 forks source link

Modify query issues when selecting samples #2669

Closed sandertan closed 7 years ago

sandertan commented 7 years ago

2 related issues:

Issue 1

In 1.7.0, when selecting samples from Study Summary, querying a gene, modifying query and requery, this error appears:

Request-URI Too Large

The requested URL's length exceeds the capacity limit for this server.

Example Study View of Genie: http://www.cbioportal.org/genie/study?id=genie_public#summary Select Glioblastoma Multiforme from Cancer Type Detailed. Query PTEN. Modify Query. Add KRAS to query and submit.

Issue 2

When the number of samples is very large, in Modify Query Error: Bad Request is displayed:

Example Study View of MSK Impact: http://www.cbioportal.org/study?id=msk_impact_2017#summary Select Patient's Vital Status: ALIVE Query for KRAS. Modify Query. Error: Bad Request in the Select Patient/Case Set section. This issue is related to https://github.com/cBioPortal/cbioportal/issues/2668

alisman commented 7 years ago

@adamabeshouse this is fixed by the batching, correct?

adamabeshouse commented 7 years ago

yes these are both fixed