Improve performance of study view

cBioPortal / cbioportal

cBioPortal for Cancer Genomics

https://cbioportal.org

GNU Affero General Public License v3.0

656 stars 514 forks source link

Improve performance of study view #475

Closed pieterlukasse closed 8 years ago

pieterlukasse commented 9 years ago

Tasks:

profile study view to find bottlenecks: profile frontend and backend code, including DB queries.

Goals:

report with main bottlenecks identified
bottlenecks solved or addressed in specific new issues (add reference to these issues)

pieterlukasse commented 9 years ago

@aderidder : @zhx828 started an RFC document (RFC14) for this.

zhx828 commented 8 years ago

ScatterPlot Optimization SHA: d8b6573943bd28d9c1b32ff4d4238f294ec42d86 SurvivalPlot Optimizations SHA: c1511c5539f9ad70e332ff30a0351755c5cc36da SHA: f956b25661f72f975d0a1174efa08046ebbc4a1d PieChart Optimizations SHA: 28963c9bd17124d7128c8d798542498d5fe5ad60 SHA: 1f9338d19e8c9389930496bb1680fd1cc26a88f7 SHA: 2a6e2c590d660567bbf048f0b370cce63ca7c873 Table Optimizations SHA: f9ccd3b6afc451a54f511e5818549bc4000e0b4f

zhx828 commented 8 years ago

Help needed on the Table.js initDataTable function. Looks like most of time has spend on redrawing the dataTable. I couldn't find any better solution for this except using other library.

You might want to use my branch to do the further improvement. (https://github.com/zhx828/cbioportal/tree/study-view)

zhx828 commented 8 years ago

Help also needed on drawPlots function in StudyView ScatterPlot(https://github.com/zhx828/cbioportal/blob/study-view/portal/src/main/webapp/js/src/study-view/component/ScatterPlots.js). This is more like d3 performance issue. May need to find a better method.

pieterlukasse commented 8 years ago

Hi @zhx828 , thanks for sharing the improvements. For your information, @aderidder and I are also looking at ways to improve some bottlenecks. We have worked on improving performance related to:

qtips in query form case lists
qtips and timeout in query results page: Plots view, Enrichment tab,
improvements in query results page to ensure each tab only gets loaded when clicked

We are also planning to improve some parts of Study view like the Datatables .