cBioPortal / cbioportal

cBioPortal for Cancer Genomics
https://cbioportal.org
GNU Affero General Public License v3.0
633 stars 487 forks source link

Timeline enhancements for GENIE's PRISSMM format #7066

Closed inodb closed 3 years ago

inodb commented 4 years ago

Visual:

Visual and need data:

For timeline 2.0 (the new refactored React based timeline):

Data related:

The above list was created from: https://docs.google.com/document/d/14__bVskxb27bp1uObue43_jYcT8qv7KmOhjunLPbaYQ/edit. There are more data requirements in that document

Current example:

https://genie-private.cbioportal.org/patient?studyId=nsclc_genie_bpc&caseId=GENIE-DFCI-000036

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jjgao commented 4 years ago

We should prioritize this one.

jjgao commented 4 years ago

added this epic to #7520.

alisman commented 4 years ago

@schultzn @inodb is the following track ordering what we want?

image

schultzn commented 4 years ago

This looks mostly good.

But the regimens are not resolved properly. Multiple drugs as given as part of a regimen (Cancer-Directed Drug 1 + Cancer-Directed Drug 2, etc.) should appear together in the timeline.

Let me know if you have any questions about this.

On Jul 6, 2020, at 6:04 PM, alisman notifications@github.com wrote:

@schultzn https://github.com/schultzn @inodb https://github.com/inodb is the following track ordering what we want?

https://user-images.githubusercontent.com/186521/86653385-250ece80-bfb3-11ea-8029-d378512b5cce.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cBioPortal/cbioportal/issues/7066#issuecomment-654488600, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2XPYDPMDCS7WI3XPTHVRDR2JDANANCNFSM4KMJOMYQ.

alisman commented 4 years ago

@schultzn just to confirm, this it should like it does in old timeline (bottom): image

schultzn commented 4 years ago

We should plan this carefully.

Drugs should be ordered in the same they were in the old timeline. And drugs given as a regimen should appear together, with drug 1 listed first, etc.

We can think about other ways to visually indicate that the drugs belong together, but that is optional.

N

On Jul 8, 2020, at 12:31 PM, alisman notifications@github.com wrote:

@schultzn https://github.com/schultzn just to confirm, this it should like it does in old timeline (bottom): https://user-images.githubusercontent.com/186521/86945220-cf533700-c116-11ea-94d3-c80671181890.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cBioPortal/cbioportal/issues/7066#issuecomment-655625288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2XPYCL37CAKXBKWU6JHVTR2SNMTANCNFSM4KMJOMYQ.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

inodb commented 3 years ago

let's confirm if all of these are solved

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.