Study with clinical data only fails to load since v3.2.11

cBioPortal / cbioportal

cBioPortal for Cancer Genomics

https://cbioportal.org

GNU Affero General Public License v3.0

636 stars 487 forks source link

Study with clinical data only fails to load since v3.2.11 #7800

Closed AndyBlake closed 4 years ago

AndyBlake commented 4 years ago

Hiya I have a study that only contains clinical patient data which loads and displays fine on 3.2.10 but some change in v3.2.11has broken the study summary page as shown in pictures. 3 2 10 3.2.10 everything fine 3 2 11 3.2.11 sample and patient numbers fail to load and the group panel also fails 3 4 8 3.4.8 same issue Can this be fixed please?

inodb commented 4 years ago

@AndyBlake seems like an issue with the session-service connection.

Some thoughts/questions:

Could you check the network tab in your browser and see what error it gives?
It might also help to check the logs in the session-service
If it's only that specific study that's failing it might be related to specific data for that study in the session-service database. You could try to deploy a session service with an empty database to see if that makes the issue go away?

Maybe @kalletlak has some more thoughts on how to debug

AndyBlake commented 4 years ago

Thanks for getting back to me - I'll check and get that info to you. Perhaps we are seeing a problem with the lack of genomic data causing the summary to fail rendering the genomic summary panel which then has knock on effect on the rest of the js causing the session setup to fall over? The session service works fine on other studys. Just a guess really. - I'll add some mutations to that study to see if it fixes everything as a way to isolate the issue.

AndyBlake commented 4 years ago

Hiya I added a mutation to one of the samples and it fixes everything. with one mutation added

inodb commented 4 years ago

Thanks for sharing @AndyBlake - so I guess the issue is that the study view doesn't work if it only contains clinical data?

AndyBlake commented 4 years ago

Yeah - I guess not your typical use case but cbioportal is really good for viewing clinical and summary data before the genomic data is available. Could a check be added to make it fail less terminally in this case? Thanks for your time. Kind regards Andy

On Wed, 19 Aug 2020, 20:43 Ino de Bruijn, notifications@github.com wrote:

Thanks for sharing @AndyBlake https://github.com/AndyBlake - so I guess the issue is that the study view doesn't work if it only contains clinical data?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cBioPortal/cbioportal/issues/7800#issuecomment-676623408, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALBROW674QS2RXUEZWXCE3SBQTNFANCNFSM4P7PQOTA .

inodb commented 4 years ago

@AndyBlake Def - thanks for reporting!

jjgao commented 4 years ago

I created an issue and see if we can support study view w/o profiles: https://github.com/cBioPortal/cbioportal/issues/7814