Closed tmazor closed 4 years ago
Thanks Tali!
Hm, that explains why the Netherlands looks so granulated. I'll try to find a map that has the lines drawn at the province level.
Edit:
For 3), I had the table row and Marker be light blue when selected (they're actually very close shades of blue, but the row's blue has the same darkness as its gray rows). Sjoerd suggested to pick a more contrasting color for the highlight on the map.
So, making the markers light blue by default (with dark blue highlight) might lead to the contrast issue Sjoerd mentioned. I played around with the cBioPortal colors using coolors and wondered if I should use a shade of light blue that's more saturated?
This is the current default Marker color:
This is the new Marker highlight color I had in mind (contrasted with default color):
This is the current Marker highlight color (contrasted with default color):
@jtquach1 your proposed color update with 2C609C looks good to me!
@jtquach1 for 2, sorry I think my request wasn't clear - I was imagining something like this: This way the header never changes, and the second line with text can just be replaced by the table when something gets selected.
@jtquach1 your proposed color update with 2C609C looks good to me!
I forgot to mention, I try to keep the marker highlight and table row highlight the same (for consistency), so this is the current view: Although I'm not sure if the dark table rows look okay with that shade of blue. Or instead I could make them have the default marker color like so:
Luke also suggested I could animate the Markers when they're selected to make them pop out more.
I like "Selected instance details" more (that suggestion was from JJ) since "Details" alone feels kind of general- I'm not sure..
@jtquach1 now that I see it in your screenshot, I agree, let's call it "Selected Instance Details" and then keep the line of text I proposed below it. All the other updates are looking great!
Also @jtquach1 - I like the idea of animating the markers when they are selected. I'm not sure I know exactly what that means, but I like doing something to help the user find their marker of interest.
Here is the current view with animated highlighted markers and a darker highlight:
I've just revised the highlighted marker animation so it only grows and shrinks back to original size once:
awesome @jtquach1 !
The map looks awesome @jtquach1 ! Here's some feedback: