cBioPortal / clinical-timeline

Use d3-timeline to visualize clinical data

GNU Lesser General Public License v3.0

22 stars 18 forks source link

made changes in exportTimeline.js to resolve issue #80 #109

Closed ayush-k closed 7 years ago

ayush-k commented 7 years ago

Signed-off-by: ayush kataria ayushkataria@ayushs-MacBook-Pro.local

What? Why?

Fix #80

Changes proposed in this pull request:

a changed the generateSVG() to include css styling directly
b changed the generatePNG() to include css styling directly

Checks

[ clinical-timeline (2).pdf

] Single commit and No merge commits
[x] Make sure your commit messages end with a Signed-off-by string (this line can be automatically added by git if you run the git-commit command with the -s option).

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif here with e.g. GifGrabber.

Notify reviewers

@inodb

ayush-k commented 7 years ago

I think I got it this time , although there is slight code repetition thus it fails one of the tests . Can you please look at it once

inodb commented 7 years ago

@ayush-k Nice quick fix! I fixed the test issues, thanks so much! See your commit in master here: https://github.com/cBioPortal/clinical-timeline/commit/a3ca4e3f12deb20b67c0dea308dd16b2eafb6f19. Feel free to contribute more and let me know if u have any questions!