cBioPortal / clinical-timeline

Use d3-timeline to visualize clinical data
GNU Lesser General Public License v3.0
22 stars 18 forks source link

Trimming updated #87

Closed rohangoel96 closed 8 years ago

rohangoel96 commented 8 years ago

What? Why?

Fix # .

Changes proposed in this pull request:

If this is a new visual feature please add a before/after screenshot or gif here with e.g. GifGrabber.

Notify reviewers

@inodb

inodb commented 8 years ago

Looks good :+1:! Well done!

I think only this screenshot: test/screenshots/index_html_data7_simple.png still looks like it uses a zigzag w/o a good reason, only 3y and 6y are removed.

To see if everything is working correctly. How about you try to put the code in cBioPortal and have a look at these cases:

http://localhost:8080/case.do?cancer_study_id=lgg_ucsf_2014&case_id=P04#nav_case_ids=P01,P02,P04,P05,P06,P07,P08,P09,P10,P11,P12,P13,P15,P16,P17,P18,P21,P24,P25,P26,P27,P28,P29

Let me know on slack if you need any help with running the portal