cBioPortal / datahub

A centralized location for storing curated data from cBioPortal
175 stars 120 forks source link

Validator Issues: Allow < > in NUMERIC datatype values (AGE and YEAR related) #128

Closed ritikakundra closed 4 years ago

ritikakundra commented 7 years ago

For deidentification purposes, the portal should not show age or year of birth (any PHI related attribute) pediatric and geriatric cases in the majority of studies. Therefore to capture the data, we modify the age to <18 and >89 (same with year). Validation fails this type of entry due to the datatype being Number. Can this be modified?

pieterlukasse commented 7 years ago

@ritikakundra this will need more testing in other views like study view and plots tab. How should these views deal with such data? For example:

image

Maybe @jjgao and @schultzn have an idea for this? I.e. how to plot such samples in this case?

jjgao commented 7 years ago

Good point. We could try to write some specially in frontend to handle that, but I don't think it's a high priority.

Maybe for the moment, we can allow them in the validator and ignore < or > in frontend (maybe in API?), so 89 instead of '>89' will be used?

jjgao commented 7 years ago

@zhx828 @ersinciftci what do you think?

ersinciftci commented 7 years ago

@jjgao what column of what table are we talking about?

jjgao commented 6 years ago

@ersinciftci attr_value in clinical_sample and clinical_patient

ersinciftci commented 6 years ago

@jjgao So some subset of the samples in a particular study have for example AGE values like <18, but other samples in the same study have normal number AGEs like 35?

yichaoS commented 6 years ago

public studies with this validation error "Value of numeric attribute is not a real number"

pieterlukasse commented 6 years ago

@yichaoS for the UNK, unk values you can replace these by NA.

jjgao commented 6 years ago

@ersinciftci yes.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rmadupuri commented 4 years ago

Closing this issue since both the validator and front-end now supports < >.