search

cBioPortal / icebox

very low priority issues
0 stars 0 forks source link

Relocate org.cbioportal.model and colocate unit tests #190

Open sheridancbio opened 3 years ago

sheridancbio commented 3 years ago

cBioPortal/cbioportal#8086 has introduced a new type Select for arguments to methods in the persistence-api layer.

The placement of this class in our modules and packages was discussed here

We should confirm the consensus from that conversation and relocate Select.java and SelectTest.java to the same module and same package. The proposal was to create a new module for utility classes which are part of the persistence-api interface, and perhaps also use that module for global utility classes which have no context dependency for any layers above the model layer.

pvannierop commented 3 years ago

@sheridancbio Same for util class SelectMockitoArgumentMatcher.java and AlterationFilterMockitoArgumentMatcher.java

pvannierop commented 3 years ago

@sheridancbio Same for utils class AlterationFilter.java that I was requested to create bu @Luke-Sikina

pvannierop commented 3 years ago

@sheridancbio Also have a look at AlterationFilter.java

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sheridancbio commented 3 years ago

Reopening ... this issue should be considered as part of the planned backend cleanup / performance improvement. We should continue to deconvolute modules and standardize code organization [packages].

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.