search

cBioPortal / icebox

very low priority issues
0 stars 0 forks source link

Refactor add-charts/columns button on study view #198

Open alisman opened 3 years ago

alisman commented 3 years ago

On study view, the add charts button and the columns button (on clinical data tab) use the same component in a way that is confusing. the columns buttons is essentially a repurposing of the add charts button and receives the same test id attribute, which makes testing difficult. We should refactor this.

When this is done we can unskip the test pertaining to behavior of add-charts on diffirernt tabs

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jjgao commented 2 years ago

@alisman good idea! should we have a design session on this?