cBioPortal / icebox

very low priority issues
0 stars 0 forks source link

Update swagger.config and Replace _ with - in all generic assay API endpoints and its usages #397

Open jagnathan opened 2 years ago

jagnathan commented 2 years ago

Update swagger.config to include GENE_PANEL_DATA in public APIs

Replace _ with - in all generic assay API endpoints and its usages Related to cBioPortal/cbioportal#9433

Additional end points where underscore has to be changed to hyphen (dash). "/virtual_study" "/virtual_study/save" "/custom_data/fetch" "/custom_gene_list/save" "/custom_gene_list" Frontend and backend changes have to happen together.

Backend changes

Frontend changes

jagnathan commented 2 years ago

Additional end points where underscore has to be changed to hyphen (dash). "/virtual_study" "/virtual_study/save" "/custom_data/fetch" "/custom_gene_list/save" "/custom_gene_list" Frontend and backend changes have to happen together.

These endpoints are dependent on types in Session Service. This means that the types in Session service have to change from virtual_study to virtual-study.

@RequestMapping(value = "/{type:virtual_study|group|custom_data|custom_gene_list}/{operation}/{id}", method = RequestMethod.GE

jagnathan commented 2 years ago

The redirect works including POST. CircleCI does not accept redirects while testing. Changes to the frontend are in progress.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.