cBioPortal / icebox

very low priority issues
0 stars 0 forks source link

group comparison clinical heatmap - labels after swapping axes aren't readable #416

Open tmazor opened 2 years ago

tmazor commented 2 years ago

Labels for the rows of the heatmap are only allowed to be a single letter in a circle. This is ok when the groups are in rows, since each group has a single letter label, but if you swap axes it results in labels that just show the first letter of each value, which is not enough - see example below with 6 rows all labeled 'L'

Heatmap initially: image

After swapping axes: image

https://www.cbioportal.org/comparison/clinical?sessionId=5cf82983e4b0ab4137874360

alisman commented 2 years ago

@tmazor @inodb could we disable axis swapping for heatmaps? i'm guessing that this change won't be trivial and unless it's actually useful for heatmaps ...

inodb commented 2 years ago

Wondering if for the heatmap it would be better to always show the circles for the group axis? Instead of having circles always on the left, show them wherever the groups are (be it x or y axis)

Maybe there could be another checkbox that allows one to choose between showing only circles or just group names

BasLee commented 2 years ago

@tmazor @alisman @inodb Removing the checkbox for the heatmap wouldn't be too hard. However swapping the longer labels from the X-axis to the Y-axis might be some work: if I remember correctly, the oncoprint heatmap component only supports single letter labels on the Y-axis.

NehaAr commented 1 year ago

tried to inspect the source code , changed the alignment and placement of the y axis. Even modified the spacing , but still was not able to figure out the reason behind initials. However , try inspecting the code and you can try adding static text along y axis