cBioPortal / icebox

very low priority issues
0 stars 0 forks source link

Mutational signatures can be loaded without p-value file, giving front-end issues #473

Open MatthijsPon opened 1 year ago

MatthijsPon commented 1 year ago

For proper visualisation of mutational signatures, both a contribution and pvalue file is needed. At the moment, if these conditions are met for files with a V2 extension, the mutational signatures tab is present and works. However, when loading more datasets with only contribution files, the option to switch to that data is given in the front end, but upon selection an error occurs (TypeError: undefined is not an object (evaluating 'this.uniqueSamples[0].id')).

This has to be either fixed by requiring both filetypes in the validator in the back-end, or restricting viewing in the front-end

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MatthijsPon commented 1 year ago

WIP