search

cBioPortal / mutation-mapper

GNU Lesser General Public License v3.0
13 stars 22 forks source link

Add alt property to the img tags for 508 compliance #37

Closed onursumer closed 8 years ago

pieterlukasse commented 8 years ago

hi @onursumer does this apply to both mutationMapper.js and mutationMapperTemplates.html? Then we also need to take the changes on both these files made in https://github.com/cBioPortal/cbioportal/pull/1219

pieterlukasse commented 8 years ago

@onursumer , @jjgao : how can we orchestrate this? It is high priority for us.

onursumer commented 8 years ago

Hi @pieterlukasse. Yes, this applies to both files. But, I don't see any changes in mutationMapper.js within https://github.com/cBioPortal/cbioportal/pull/1219.

The best way to manage mutation mapper changes is to create pull requests on this repository. Then I can rebuild the binaries and update the corresponding cbioportal branch (rc or hotfix).

Also note that, in this repository no one should directly modify the files in the https://github.com/cBioPortal/mutation-mapper/tree/master/build directory.

onursumer commented 8 years ago

Please create the PR on the https://github.com/cBioPortal/mutation-mapper/tree/rc branch. Files that need to be modified are located here: https://github.com/cBioPortal/mutation-mapper/tree/rc/src/html

pieterlukasse commented 8 years ago

thanks @onursumer . @fedde-s will work on this.