cBioPortal / mutation-mapper

GNU Lesser General Public License v3.0
13 stars 22 forks source link

Update mutation mapper default PDB url to the new PDB endpoint #51

Open pieterlukasse opened 8 years ago

pieterlukasse commented 8 years ago

PDB changed its endpoint for serving PDB data from http://www.rcsb.org/pdb/files/ to http://files.rcsb.org/view/ . See also https://github.com/cBioPortal/cbioportal/pull/1434.

So it would be good to update mutationMapper.js code here as follows:

        function delayedInitMutationMapper(el, options, tabs, tabName)
        {
                var mutationMapper = new MutationMapper(options);
                var initialized = false;

@@ -13516,7 +13517,8 @@ function Mutation3dVis(name, options)
                        debug: false,
                        color: "white"
                },
-               pdbUri: "http://www.rcsb.org/pdb/files/", // default PDB database URI
+               //for https, use a proxy since rcsb.org is not serving https and browsers will complain about the mixed https/http content
+               pdbUri: "http://files.rcsb.org/view/",
pieterlukasse commented 5 years ago

@onursumer can it be that this old url is still found in the rc branch? Is this dead code?

pieterlukasse commented 5 years ago

cc @jjgao

onursumer commented 5 years ago

Hi @pieterlukasse, this is the legacy mutation mapper, pretty much dead. We are using the correct url for the latest implementation: https://github.com/cBioPortal/cbioportal-frontend/blob/ad8769543e3642f3d15715305d47b7924043c146/src/shared/components/structureViewer/StructureVisualizer.ts#L71

pieterlukasse commented 5 years ago

Thanks @onursumer . I made 2 PRs to clean this up (they are referenced to this issue).