search

cBioPortal / oncotree

Creative Commons Attribution 4.0 International
35 stars 26 forks source link

Tumor Types API not supporting forward slash in query #134

Open gearve14 opened 6 years ago

gearve14 commented 6 years ago

It appears the API is not properly escaping "/" characters as it should. For example, the request url: http://oncotree.mskcc.org/api/tumorTypes/search/name/Desmoid%2FAggressive%20Fibromatosis?version=oncotree_2018_06_01&exactMatch=true&levels=2%2C3%2C4%2C5 does not recognize %2F as an escaped character and thus tries to route to a different directory, instead of returning the result for "Desmoid/Aggressive Fibromatosis".

This seems to only effect forward slashes as I have tested it with other special characters and they all work fine.

zhx828 commented 5 years ago

@sheridancbio I ran into similar issue when try to query code MDS/MPN

sheridancbio commented 5 years ago

This bug is verified. Essentially, the controller mapping/routing is mistaking the slash in the parameter text to be division ( a path parameter split ). We will look into the correct technique to escape these slashes so that they do not break up the request argument. We may need to introduce a replacement character approach if there is no natural method available. cc @ritikakundra

caaespin commented 5 years ago

Do you guys have an estimate for when this bug would be addressed?