cBioPortal / oncotree

Creative Commons Attribution 4.0 International
35 stars 26 forks source link

oncotree_to_oncotree.py should support python3 #208

Closed thomasyu888 closed 3 years ago

thomasyu888 commented 4 years ago

fixes #212 This was run with python 3.7.6

  1. urllib.urlopen is no longer a thing in python3. It is urllib.request.urlopen
  2. DeprecationWarning: 'U' mode is deprecated (It is the default in python3)
    with open(file, "rU"):
  3. oncotree_code = lists_of_all_ancestors[0][min_length - 1]
    TypeError: 'dict_values' object is not subscriptable
  4. TypeError: unsupported operand type(s) for >>: 'builtin_function_or_method' and '_io.TextIOWrapper'. Did you mean "print(<message>, file=<output_stream>)"
thomasyu888 commented 4 years ago

Not sure why the tests are failing, but would be happy to fix.

thomasyu888 commented 4 years ago

@sheridancbio . Thoughts of this?

sheridancbio commented 3 years ago

This work has been incorporated into the master branch (with adjustments) via PR #233