cBioPortal / oncotree

Creative Commons Attribution 4.0 International
35 stars 26 forks source link

oncotree node "TISSUE" is showing NCI/UMLS codes in tumorTypes API #76

Open sheridancbio opened 7 years ago

sheridancbio commented 7 years ago

curl -X POST --header "Content-Type: application/json" --header "Accept: application/json" -d "{ \"queries\": [ { \"exactMatch\": true, \"query\": \"TISSUE\", \"type\": \"code\" } ], \"version\": \"oncotree_latest_stable\" }" "http://oncotree.mskcc.org/oncotree/api/tumorTypes/search"

Returns: "data": [ [ { "id": null, "code": "TISSUE", "color": null, "name": "Tissue", "mainType": null, "tissue": null, "children": {}, "parent": null, "deprecated": false, "history": [], "links": null, "level": null, "NCI": [ "C12801" ], "UMLS": [ "C0040300" ] }

This oncotree node actually represents the root of the oncotree, and contains lymph and blood subtrees. So the definition from https://ncit.nci.nih.gov/ncitbrowser/pages/concept_details.jsf?dictionary=NCI%20Thesaurus&code=C12801 : "An anatomical structure consisting of similarly specialized cells and intercellular matrix, aggregated according to genetically determined spatial relationships, performing a specific function." does not seem to be accurate.

We should consider returning null for these (and all) meta values.

On the oncotree main webpage, the hover-over of node TISSUE displays "Not Available" for NCI and UMLS because the TISSUE node is not present in the tumor_Types.txt API output.