search

cBioPortal / oncotree

Creative Commons Attribution 4.0 International
35 stars 26 forks source link

API ignores "levels" parameter #77

Closed sheridancbio closed 5 years ago

sheridancbio commented 7 years ago

The api GET tumorTypes/search has an http parameter "levels" and the swagger page claims that this selects the range of levels in which to perform search. However, output is not filtered to include only oncotree nodes at the specified levels.

Example:

curl -X GET --header "Accept: application/json" "http://oncotree.mskcc.org/oncotree/api/tumorTypes/search/name/Breast?version=oncotree_latest_stable&exactMatch=false&levels=3"

Returns oncotree nodes at several levels, including "code": "BREAST", which is at level "PRIMARY" ; and "code": "BPT", which is at level "Quaternary"

An additional issue is that the swagger description of the levels parameter states that level 1 is the Primary level, and that contains tissue, and that it is excluded by default. But there is a node named "TISSUE" which is on a level "below" level 1 (perhaps level 0) So we should clarify what is excluded by default (the TISSUE node and all nodes at the primary level such as "Bone" and "Bowel"

sheridancbio commented 5 years ago

this was resolved some time back