cBournhonesque / lightyear

A networking library to make multiplayer games for the Bevy game engine
https://cbournhonesque.github.io/lightyear/book
Apache License 2.0
496 stars 51 forks source link

fix: Remove `ring` to fix wasm32 web builds #687

Closed cdata closed 2 days ago

cdata commented 1 week ago

Fixes #684

This is admittedly a blunt solution to the problem. For uncertain reasons, the ring dependency does not seem compatible with wasm32-unknown-unknown/wasm-bindgen builds. But: ring only seems to be used for this ~25 line utility function. So, the fix proposed here is to remove the ring dependency and inline the utility function. Submitted for your consideration!

cBournhonesque commented 2 days ago

awesome, thank you