search

cRz-Shadows / Pokemon_Crystal_Legacy

This is a Pokémon Rom Hack made by TheSmithPlays with the intended purpose of fixing Pokémon Crystal into a more polished experience while staying true to the vision of Generation 2.
72 stars 24 forks source link

Update Docs to reference appropriate RGBDS version #16

Open ccecora opened 5 days ago

ccecora commented 5 days ago

When installing, I followed the INSTALL.md and made sure to install RGBDS v0.5.2, but a check came up telling me I need v0.7.0 or later:

image

I checked this asm file and the macro refers to v0.5.2 like the docs say: https://github.com/cRz-Shadows/Pokemon_Crystal_Legacy/blob/6394641ef37d51a299a13d96ccaf0c413c6c8c42/rgbdscheck.asm#L6

I could put in a PR just updating the INSTALL.md with a reference to the right version of RGBDS in this codebase, but not sure where else it would be. Any pointers here? Thank you!

cRz-Shadows commented 5 days ago

Are you sure you are actually in the crystal legacy repo running make here? It looks like just a normal pokecrystal folder looking at your terminal.