search

cRz-Shadows / Pokemon_Crystal_Legacy

This is a Pokémon Rom Hack made by TheSmithPlays with the intended purpose of fixing Pokémon Crystal into a more polished experience while staying true to the vision of Generation 2.
72 stars 24 forks source link

Fix pokedex evo page bug for Tyrogue #5

Closed pyromaniackeca closed 2 months ago

pyromaniackeca commented 2 months ago

This user found a bug with Tyrogue's evo page where the evo conditions for Hitmonchan and Hitmonlee are reversed.

It annoyed me, so I tried to fix it for my fork and came up with this. I don't know if this is the proper fix, but it seems to fix the immediate problem.

I've tested this by changing one of the starters to Tyrogue and unlocking the dex right away for easier reproduction. I left the testing commits in here in case you wanna check/make further changes.

cRz-Shadows commented 2 months ago

Hey, this is actually already fixed for the next update, just havent pushed the commits yet. My fix was the same as yours minus the LT line at the end since it's unnecessery. I'm going to close the pull request since it would mess with my commits, but mine will be up when the update releases! Also for future, good practice is to put anything for testing in debug statmenets then use the debug rom to test, or just not commit those changes at all and do it in a local repo.

pyromaniackeca commented 2 months ago

Thanks for the confirming the fix is legit and the debug tips! I haven't done any assembly in over a decade, so don't really know what I'm doing. :smile:

As for the test commits, I figured they might be useful and you can squash everything at the end anyway. Will go with debug statements in the future.