search

cScotPlay / Rusticated

Rusticated is an updated and reinvigorated mod based on our beloved, Rustic.
2 stars 1 forks source link

[1.20.1] Crash With Terralith #23

Open CraftyZombie opened 7 months ago

CraftyZombie commented 7 months ago

Versions: Fabric Loader 0.15.7 FAPI:0.92.0+1.20.1 Rusticated 3.0.1 Terralith 2.4.11

Game crashes on chunk load.

Logs: Latest.log and Crash Report here: https://gist.github.com/CraftyZombie/3e09ce2a2763345dd712d517f1262a66 (Debug.log was not generated.)

Additional Information: This may be a similar type of issue that Cyclic had with world-gen mods.

Here's the issue and pull request for that, including how it was fixed: https://github.com/Lothrazar/Cyclic/pull/2387

(Note that Cyclic is on Forge so it probably works a little differently.)

CraftyZombie commented 7 months ago

Issue seems to be hard-coded into the mod due to this class: https://github.com/cScotPlay/Rusticated/blob/1.20_fabric/src/main/java/net/mcs3/rusticated/world/level/levelgen/generation/VegetationGeneration.java

The code attempts to place olive trees and forest herbs twice in the Yosemite Lowlands (added by Terralith), which are tagged as both forest and taiga, causing the crash.