cYbercOsmOnauT / wysiwygsceditorphpbb

8 stars 11 forks source link

BBCodes added by this extension are not parsed #12

Closed Zoddo closed 9 years ago

Zoddo commented 9 years ago

The BBCodes added by this extension are not parsed as in this screenshot:

capture

cYbercOsmOnauT commented 9 years ago

This means that the migrations were not inserted into the database. Try to disable, Delete data (not really needed, just to be sure) and reenable the Extension. I don't know how simple INSERT queries did not work on your database.

cYbercOsmOnauT commented 9 years ago

Or did you maybe install another extension later that deleted this bbcodes from the database? I don't know.

Zoddo commented 9 years ago

I tested with a phpBB 3.1.5 freshly installed via quickinstall.

The BBCodes appears in the ACP but doesn't work even after a clean of the cache.

Zoddo commented 9 years ago

When I delete and recreate a BBCode, it's correctly parsed.

cYbercOsmOnauT commented 9 years ago

What is quickinstall? Please install it the way it should be by enabling it on the ACP - Customize. I guess your quickinstall does not do the Migrations part.

Zoddo commented 9 years ago

QuickInstall installs phpBB, not the extensions.

See https://www.phpbb.com/customise/db/official_tool/phpbb3_quickinstall/

cYbercOsmOnauT commented 9 years ago

Ah okay.. so that means that this Quickinstall activates the extensions but is not going through their migrations. Also Quickinstall is for phpBB 3.1.3. My extension is optimized for phpBB 3.1.5 and greater. Should still be no problem. I think the problem is on the Quickinstall side and you should talk to the creator of this thing. When you activate the WYSIWYG editor manually on one board you will see that everything works fine. So please ask the right person ;) I am not here to fix the fault of his script.

Zoddo commented 9 years ago

QuickInstall isn't an extension, but a tool (developed by the phpBB team) that installs phpBB in one click. I install/activate the extension with the normal way on the ACP > Customize.

A user on the French community has experimented the same issue : http://forums.phpbb-fr.com/extensions-support-independantes-phpbb31/sujet205486.html (he haven't installed his board with quickinstall)

cYbercOsmOnauT commented 9 years ago

I don't speak french.. sorry ;)

Zoddo commented 9 years ago

Yes, that's why I reported the issue here :)

cYbercOsmOnauT commented 9 years ago

I tried it out on my testboard (3.1.5). Disabled the extension. Deleted its data.. all new BBCodes were gone. Then I enabled it again.. looked inside POSTING - BBCodes and what did I see? All the BBCodes that were added by my extension.

I cannot see any faulty behaviour here.

Zoddo commented 9 years ago

The BBCodes appears in the ACP but doesn't work even after a clean of the cache. When I delete and recreate a BBCode, it's correctly parsed.

I think you should to test with a freshly installed board without other extensions :)

cYbercOsmOnauT commented 9 years ago

But how can they not work when you see them in the ACP? This extension only changes the way of parsing for color and size. All other BBCodes are parsed the normal way. So if you see them inside the BBCodes tab it means that they also get parsed.

Zoddo commented 9 years ago

Ok, I've find what is the bug. It's because the migrations start the insertion of BBCode from id "1" (if there is no other bbcodes).

You need to check that ids of your custom bbcodes is greater than the core bbcode ids. See the ACP module

Note: always dev/test his extension from a clean board ;)

cYbercOsmOnauT commented 9 years ago

No I don't start with 1

https://github.com/cYbercOsmOnauT/wysiwygsceditorphpbb/blob/master/cosmo/sceditor/migrations/bbcodedata.php

Look at the lines 44 and below

Zoddo commented 9 years ago

If there not other custom bbcodes, it's start with "1".

image

cYbercOsmOnauT commented 9 years ago

Ah... now I understand what you meant. Okay, that can be fixed fast... wait a minute ;)