cYbercOsmOnauT / wysiwygsceditorphpbb

8 stars 11 forks source link

nested lists fully broken #21

Closed naturalgeek closed 7 years ago

naturalgeek commented 7 years ago

Tested on 3.1.10 and 3.2.0

when you create a nested list, the output BB Code is wrong!

Output is:

[ul] [li]eins[/li] [ul] [li]zwei[/li] [ul] [li]drei[/li] [/ul] [/ul] [/ul]

Instead of:

[ul] [li]eins [ul] [li]zwei [ul] [li]drei[/li] [/ul] [/li] [/ul] [/li] [/ul]

This example is made in phpbb 3.2, the problem also exists on phpbb 3.1 but with [list] instead of [li] when i paste richtext, there will be also some [/ul] tags replaced with [/ol]. no idea why.

I will try to fix it but if someone is more familiar with the codebase it might be more easy to fix for you

Thx!

davidshq commented 7 years ago

I've experienced the same issue as well.

naturalgeek commented 7 years ago

seems to be not related to this project but:

https://github.com/samclarke/SCEditor

cYbercOsmOnauT commented 7 years ago

I will update SCEditor. Lets see if that will solve the problem.

cYbercOsmOnauT commented 7 years ago
[ul]
[li]eins
[ul]
[li]zwei
[ul]
[li]drei[/li]
[/ul]
[/li]
[/ul]
[/li]
[/ul]

Used this with SCEditor 1.5.2. Clicked on Preview.. and back.. posted... edit... still the same

naturalgeek commented 7 years ago

i've created a bug report for SCEditor too

https://github.com/samclarke/SCEditor/issues/553

cYbercOsmOnauT commented 7 years ago

It's definitely a problem with SCEditor. This is the HTML that gets created inside the WYSIWYG Editor.

<ul>
  <li>One</li>
  <ul>
    <li>Two</li>
    <ul>
      <li>Three</li>
    </ul>
    <li>Two</li>
  </ul>
  <li>One</li>
</ul>
naturalgeek commented 7 years ago

Fixed in SCEditor: https://github.com/samclarke/SCEditor/issues/553

cYbercOsmOnauT commented 7 years ago

Thanks. I am just not sure if I should put a quickfix into my code or better wait for the release of v2 from SCEditor.

naturalgeek commented 7 years ago

quickfix branch! :)