ca-archived / iOS-NBUImagePicker

Modular image picker with Simulator-compatible AVFondation camera, assets library, filters and more.
http://cyberagent.github.io/iOS-NBUImagePicker
Apache License 2.0
193 stars 48 forks source link

NBUCoreImageFilterProvider [ciImage autoAdjustmentFilters]; No longer exists in iOS 9 #15

Closed DanH-SyncInteractive closed 8 years ago

DanH-SyncInteractive commented 9 years ago

NBUCoreImageFilterProvider.m

+ (UIImage *)applyFilters:(NSArray *)filters
                  toImage:(UIImage *)image

NSArray * autoFilters = [ciImage autoAdjustmentFilters];

autoAdjustmentFilters throws an error in the current XCode7 Beta. The function is now autoAdjustmentFiltersWithOptions

rivera-ernesto commented 9 years ago

It probably depends on what deployment iOS version you have. We may need to check for availability and choose which one to use.

DanH-SyncInteractive commented 9 years ago

This is iOS9

rivera-ernesto commented 9 years ago

As of iOS 8 autoAdjustmentFilters was not deprecated so I am pretty sure it does exist in iOS 9, maybe deprecated and throwing an error, but should exist.

Anyway feel free to submit a pull request using the autoAdjustmentFiltersWithOptions: which exists since iOS 5.

DanH-SyncInteractive commented 9 years ago

This is using the latest Xcode 7

rivera-ernesto commented 9 years ago

As I said, feel free to submit a pull request. I think using autoAdjustmentFiltersWithOptions: should work with al versions.

riksof-abdulrauf commented 8 years ago

Hi, How can I get the new Apple default filters in

// Get only the core image filters.
NSArray *filterTypes = [NBUFilterProvider availableFilters];

img_0345

rivera-ernesto commented 8 years ago

You can execute this commented code.

Also we would need to add new filters to that same file. Please create a new issue to discuss this.

almoehi commented 8 years ago

are you planning to publish an updated cocoapod including this fix? It's basically blocking all developments on xcode 7.3 / iOS9 ...

rivera-ernesto commented 8 years ago

Sadly I am not actively using the library but it would be great to have a pull request to fix that.