ca-x / vivaldi_plus

根据shuax chrome_plus 修改
MIT License
162 stars 29 forks source link

Sweep:Please Add Surpport to this project to read config from ini #14

Closed czyt closed 1 year ago

czyt commented 1 year ago

please use builtin GetPrivateProfileXXX to read ini file, the ini file locates in the same dir of the binary dir.the ini file sample:

[opt]
UserData=%app%/../UserData
CacheDir=%app%/../Cache
Checklist - [X] ``src/portable.h`` ✅ Commit [`5dc5626`](https://github.com/czyt/vivaldi_plus/commit/5dc5626f6f372c7b5583dd488e846954026f9f44)
sweep-ai[bot] commented 1 year ago

Here's the PR! https://github.com/czyt/vivaldi_plus/pull/16.

⚡ Sweep Free Trial: I'm creating this ticket using GPT-4. You have 4 GPT-4 tickets left for the month and 2 for the day. For more GPT-4 tickets, visit our payment portal.

Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/czyt/vivaldi_plus/blob/313f9695a8addfca87ba533327d3f03b587ed906/src/portable.h#L1-L145 https://github.com/czyt/vivaldi_plus/blob/313f9695a8addfca87ba533327d3f03b587ed906/src/TabBookmark.h#L249-L427 https://github.com/czyt/vivaldi_plus/blob/313f9695a8addfca87ba533327d3f03b587ed906/src/appid.h#L1-L41

Step 2: ⌨️ Coding

trunk fmt `src/portable.h` 1/4 ✓

Checked 1 file
✔ No issues
trunk check --fix --print-failures `src/portable.h` 2/4 ✓

Checked 1 file
✔ No issues
trunk fmt `src/portable.h` 3/4 ✓

Checked 1 file
✔ No issues
trunk check --fix --print-failures `src/portable.h` 4/4 ✓

Checked 1 file
✔ No issues


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/read-ini-config.

.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord