search

caarlos0 / speedtest-exporter

Exports speedtest-cli metrics in the prometheus format
Apache License 2.0
50 stars 7 forks source link

Use open-source `speedtest-cli` instead of closed source `speedtest`? #13

Open bjornfor opened 1 year ago

bjornfor commented 1 year ago

Hi, thanks for making this exporter!

I noticed it relies on the closed source speedtest CLI from speedtest.net, but there is an open source alternative at https://github.com/sivel/speedtest-cli -- would you consider switching / accept a PR?

bjornfor commented 1 year ago

I found that this project started out with speedtest-cli but changed to the closed source speedtest in c77fb7863788297cdf715263ebd983ca227e7867 and 5a2ec39485a76b3e12ca12a7b3ce4401de4e8f20. I wonder why though -- the commit messages don't say.

jessemillar commented 1 year ago

There's a decent number of caveats listed at the bottom of the open-source speedtest-cli. As a random internet person who just started using this exporter today, I'd probably lean toward keeping the official speedtest.net version for reliability/accuracy.