Migrate some ObservableFields to LiveDatas. - Githubissues

caarmen / poet-assistant

Android app with rhyming dictionary, thesaurus, and dictionary, with text-to-speech functionality to read your poem.

Other

83 stars 11 forks source link

Migrate some ObservableFields to LiveDatas. #103

Closed caarmen closed 6 years ago

caarmen commented 6 years ago

When to use ObservableFields:

when they are referenced from xml for databinding

When to use LiveData:

all other cases (of notifying the activity/fragment to update the ui).

I prefer LiveData over ObservableField when possible because:

LiveData observers will only be triggered when the activity is resumed
The observers can directly be lambdas: no need for the BindingCallbackAdapter workaround.
Don't need to explicitly unregister the observers in onDestroy()