search

caarmen / poet-assistant

Android app with rhyming dictionary, thesaurus, and dictionary, with text-to-speech functionality to read your poem.
Other
85 stars 11 forks source link

allow disabling some category tabs #185

Open in-plaintext opened 12 months ago

in-plaintext commented 12 months ago

Required before filing an issue:

I am a:

[x ] Real user of Poet Assistant [ ] Student or researcher [ ] Reporting an issue found by a software analysis or automation tool [ ] Other: Please explain

I never use the 'rhymer' and 'reader' features, in addition to 'favorites'. There's an entry in the Android share menu (without any title) for all 'rhymer','thesaurus' and 'dictionary' while the copied & shared text (Android 13+) appears to always be opened in 'reader'.

Since for instance Termux doesn't use the standard Android share menu, Poet Assistant can't practically be effectively used with the app. Words have to be copied manually to Poet Assistant.

Android 13 / LineageOS 20

caarmen commented 12 months ago

I did a quick test on Android 13, and when I selected "rhymer" from the share menu, it opened in the rhymer tab. 🤔 Perhaps I didn't use the same steps you were using.

Before looking into this in more detail, could you please let me know which version of the app you're using? The "reader" tab was renamed to "composer" in version 1.28.0.

Thanks!

in-plaintext commented 12 months ago

could you please let me know which version of the app you're using? The "reader" tab was renamed to "composer" in version 1.28.0.

I'm using the current 1.30.6: version, but copied the tab names from an online image search. I'm sorry.

I don't think I'm shown any names for the Poet Assistant share tiles (note the phone layout):

screenshot

the context menu (accessed via the three-dot "hamburger icon) doesn't have any either:

screenshot (had to be captured from a screen-recording)

in-plaintext commented 12 months ago

while the copied & shared text (Android 13+) appears to always be opened in 'reader'.

Since for instance Termux doesn't use the standard Android share menu, Poet Assistant can't practically be effectively used with the app. Words have to be copied manually to Poet Assistant.

Some clarification for the Termux issue — the app has its own context menu ( via 'more...') and Poet Assistant only has one entry when sharing text, seemingly always defaulting to 'composer':

https://github.com/caarmen/poet-assistant/assets/151938484/b5dae5ac-0250-480e-8177-4426c77118f4

in-plaintext commented 12 months ago

Nonetheless I'll leave the issue open, in my view it's worthwhile to have options for removing unwanted entries from the app and Android context menus.

caarmen commented 12 months ago

the context menu (accessed via the three-dot "hamburger icon) doesn't have any either:

screenshot (had to be captured from a screen-recording)

Could you let me know what app this screenshot is from?

Looks like the menu works fine from Chrome:

https://github.com/caarmen/poet-assistant/assets/1731388/37096a82-34d4-496e-ba4f-ad88b6989fb9

caarmen commented 12 months ago

For info, this may not apply exactly to what you're looking for, but there is a setting to disable poet assistant tabs from appearing in the context menu (like when selecting text inside chrome). It applies to all tabs though, there's not a separate setting for each tab:

caarmen commented 12 months ago

As for termux, I didn't try that app, but it's a different entry point into poet assistant: it's a "share" functionality. It's true, the share functionality currently only opens in the composer tab.

So if I can summarize the issues (of this ticket):

in-plaintext commented 12 months ago

Could you let me know what app this screenshot is from?

fennec_fdroid (a Firefox for Android fork)

Android 13 / LineageOS 20

caarmen commented 12 months ago

For info, I've opened a PR in termux, so that it can show text processing apps (like poet assistant rhymer/thesaurus/dictionary, wikipedia, google translate...) from the text selection menu. https://github.com/termux/termux-app/pull/3720

caarmen commented 12 months ago

Could you let me know what app this screenshot is from?

fennec_fdroid (a Firefox for Android fork)

Android 13 / LineageOS 20

Thanks! I opened an issue over there about the incorrect labels appearing: https://gitlab.com/relan/fennecbuild/-/issues/58

Looks like I found the line of the code with the bug, but opening a PR for that project is a bit overwhelming (the bug is in geckoview, which looks like a huge project with a complicated build system).