caas-team / GoKubeDownscaler

A horizontal autoscaler for Kubernetes workloads
GNU General Public License v3.0
9 stars 4 forks source link

Implement missing Runtime Configurations and Values #26

Closed jonathan-mayer closed 2 months ago

jonathan-mayer commented 3 months ago

Issue

Some Configurations aren't implemented yet:

Also currently the Time Annotation is an layer value. This needs to be changed, as it is only supposed to be set via the cli arguments and doesn't need to be in the Layer struct.

Problem to solve

Implement the cli arguments and values. Remove the time annotation value from the layer struct and make a variable in main that holds the runtime configuration value.

Further details

once #27 is implemented, the matching labels could be implemented by iterating over the annotations and checking via the new function using fmt.Sprintf("%s=%s", annotation, value)

Proposal

Who can address the issue

Other links/references

jonathan-mayer commented 3 months ago

still have to do: dry-run exclude namespaces exclude workloads

and test the matching-labels

jonathan-mayer commented 2 months ago

to implement dry run i probably have to wait for #31 to merge

jonathan-mayer commented 2 months ago

dry run should also stop error events from being applied to the workload