caas-team / GoKubeDownscaler

A horizontal autoscaler for Kubernetes workloads
GNU General Public License v3.0
8 stars 4 forks source link

Check pre commit workflow #43

Closed jonathan-mayer closed 1 month ago

jonathan-mayer commented 1 month ago

Issue

Many Contributors might not have pre commit installed or forgot to execute pre-commit install in the repository. This results in problems if the reviewers forget to check if pre commit was run properly and doesnt give an error, which results in branches from the commit in main all having the pre commit problems, having to resolve them in each branch which then again leads to more merge conflicts.

Further details

The pre-commit/action could be used, although it is in maintenance only mode. You could also possibly find a maintained action that does this. Or check out pre-commit ci for organization repositories

Proposal

We need an automatic way of running pre commit and seeing if there are any problems. This could be resolved using a Workflow, a GitHub app or anything that works here. The check doesn't need to, but it would be nice if it would automatically push changes made to files the checks.

Who can address the issue

Other links/references

https://pre-commit.ci/

jonathan-mayer commented 1 month ago

There are 2 versions of the github app:

https://github.com/marketplace/pre-commit-ci-lite and https://github.com/marketplace/pre-commit-ci