Initially the target manager was built to implement the feature of #30 asap. The manager logic was implemented in a way around the gitlab API interactions. To be able to support other remote state backends for global registration we need to genericize the target manager.
Changes
Pretty much everything is moving and renaming in this PR.
The only thing I've really changed is that the config now has a type which specifies the type of the remote interactor used kind of like we already do for the loader.
The new target manager config looks like this:
targetManager:
type: gitlab # <- This is the new type config option.
checkInterval: 1m
registrationInterval: 1m
updateInterval: 2m
unhealthyThreshold: 3m
gitlab:
baseUrl: https://gitlab.com
projectId: 123456
I'll change the docs and chart for this later with the last PR regarding #66 that will close the issue.
refactor: generalize Gitlab interface to remote interactor interface
refactor: mv gitlab config to interactor config
chore: adjust imports
feat: add interactor type
feat: adjust target manager validation for interactor type
chore: adjust naming
chore: bump helm-docs v1.13.1
For additional information look at the commits.
Tests done
[x] Unit tests succeeded
[ ] E2E tests succeeded - we have no e2e tests for the target manager
Motivation
This is the second PR to address #66.
Initially the target manager was built to implement the feature of #30 asap. The manager logic was implemented in a way around the gitlab API interactions. To be able to support other remote state backends for global registration we need to genericize the target manager.
Changes
Pretty much everything is moving and renaming in this PR.
The only thing I've really changed is that the config now has a type which specifies the type of the remote interactor used kind of like we already do for the loader.
The new target manager config looks like this:
I'll change the docs and chart for this later with the last PR regarding #66 that will close the issue.
For additional information look at the commits.
Tests done
Manual e2e tests
Logs
Remote Repository
TODO