caas-team / sparrow

A monitoring tool to gather infrastructure network information
Apache License 2.0
6 stars 4 forks source link

Code smell: no error returned in any controller function #123

Closed puffitos closed 2 months ago

puffitos commented 3 months ago

Is there an existing issue for this?

Current Behavior

During https://github.com/caas-team/sparrow/issues/37 I noticed that the ChecksController doesn't ever return an error in any of its functions, as they are all throttled down the error channel.

When the err is always nil, then it should not be part of the function's signature :)

Expected Behavior

No error as a return parameter.

Steps To Reproduce

No response

Relevant logs and/or screenshots, environment information, etc.

No response

Who can address the issue?

Everyone

Anything else?

No response