We're now handling the os shutdown signals so the sparrow still shuts down, even in case of a controlled shutdown. This also addresses the bug that sparrow instances stay registered on the remote repository even though the sparrow instance doesn't run anymore.
Additionally to that I've adjusted the README to the changes made in #122 and removed the error handling of the (*Sparrow).Run method because it's always non nil.
feat: add os signal handling for graceful shutdown
chore: housekeeping
For additional information look at the commits.
Tests done
[x] Unit tests succeeded
[ ] E2E tests succeeded - we have none for graceful shutdown
Motivation
To address this conversation https://github.com/caas-team/sparrow/pull/125#discussion_r1525406062
Changes
We're now handling the os shutdown signals so the sparrow still shuts down, even in case of a controlled shutdown. This also addresses the bug that sparrow instances stay registered on the remote repository even though the sparrow instance doesn't run anymore.
Additionally to that I've adjusted the README to the changes made in #122 and removed the error handling of the (*Sparrow).Run method because it's always non nil.
For additional information look at the commits.
Tests done
TODO