search

caas-team / sparrow

A monitoring tool to gather infrastructure network information
Apache License 2.0
6 stars 4 forks source link

Bump chart's appVersion and fix chart repo on release job #129

Closed puffitos closed 2 months ago

puffitos commented 2 months ago

Motivation

The appVersion was false and the helm release job was pushing to a wrong repo.

Changes

See commits.

Tests done

None, seems pretty straightforward.

TODO

lvlcn-t commented 2 months ago

Can you also adjust the latest version in the README?

https://github.com/caas-team/sparrow/blob/main/README.md?plain=1#L84

puffitos commented 2 months ago

Can you also adjust the latest version in the README?

https://github.com/caas-team/sparrow/blob/main/README.md?plain=1#L84

Sorry, I don't think this is something we should do. Manual updates of the README, just to show how to install a specific version, don't really add any value to sparrow. It's nice updating everything and polishing the documentation every now and then, but this is where we should draw a line. Showing once how it's done is more than enough.

We already have to update the chart version manually each time we change something, and we need to remember to change the appVersion as well when we bump the sparrow's version. That's enough busywork for me.