caas-team / sparrow

A monitoring tool to gather infrastructure network information
Apache License 2.0
6 stars 4 forks source link

Feat/https for everyone #145

Closed niklastreml closed 3 weeks ago

niklastreml commented 3 weeks ago

Motivation

Closes #144

This pr implements the features requested in #144

Serve API over https

Adds a tls config to allow configuring the server to use https instead of http

HTTP targets in targetmanager

Changes the targetmanager to allow non https targets by setting a new scheme value in the config

Enabled flag for targetmanager

To make our lives a bit easier when dealing with default values, I've added a flag to the targetManager config for enabling it explicitly instead of implicitly enabling it as we did before

Changes

For additional information look at the commits.

Tests done

TODO

y-eight commented 3 weeks ago

Looks quite good to me!