caas-team / sparrow

A monitoring tool to gather infrastructure network information
Apache License 2.0
6 stars 4 forks source link

Bug: First registration is always https #151

Closed niklastreml closed 2 weeks ago

niklastreml commented 3 weeks ago

Is there an existing issue for this?

Current Behavior

The first time targetmanager registers itself in the remote, it uses https instead of the configured scheme. This is because I forgot to change the register function of the target manager to the new behaviour.

Expected Behavior

Sparrow registers with the configured scheme

Steps To Reproduce

  1. Run with any config that sets targetmanager.scheme to http
  2. Observe Gitlab Repo
  3. The Initial registration commit will be https

Relevant logs and/or screenshots, environment information, etc.

No response

Who can address the issue?

No response

Anything else?

No response