search

caas-team / sparrow

A monitoring tool to gather infrastructure network information
Apache License 2.0
6 stars 4 forks source link

feat: Prepare helm chart for 0.3.0 #73

Closed niklastreml closed 8 months ago

niklastreml commented 8 months ago

Motivation

Since #69 added servicemonitors to the helm chart, we should also bump the chart version.

Changes

For additional information look at the commits.

puffitos commented 8 months ago

Can the chart be deployed in its current state?

eumel8 commented 8 months ago 
panic: failed to read config file open tmconfig.yaml: no such file or directory

so, this is required?

puffitos commented 8 months ago 
panic: failed to read config file open tmconfig.yaml: no such file or directory

so, this is required?

We should release 0.0.3 and use that image for the chart. Once #65 is merged, we're good to go.

niklastreml commented 8 months ago

I've bumped the charts appVersion to v0.3.0 to prepare for release

lvlcn-t commented 8 months ago

I've fixed a bug where the yaml couldn't be parsed if the service monitor is enabled but no labels were set.

Now values like this are vaild:

# -- Configure a service monitor for prometheus-operator
serviceMonitor:
  # -- Enable the serviceMonitor
  enabled: true
  # -- Sets the scrape interval
  interval: 30s
  # -- Sets the scrape timeout
  scrapeTimeout: 5s
  # -- Additional label added to the service Monitor
  labels: {}
niklastreml commented 8 months ago

please look at #75, as that pr fixes e2e and allows us to properly test 0.3.0 internally

y-eight commented 8 months ago

Pls look at last 2 comments https://github.com/caas-team/sparrow/pull/75

niklastreml commented 8 months ago

there is still a bug with marshalling env variables correctly, it is semi fixed in viper 1.18.0 but was hidden behind a feature flag in 1.18.2 due to causing a different bug. That bug only appears when using fun stuff like pointer pointers, so we should be fine I think.

https://github.com/spf13/viper/pull/1429 https://github.com/spf13/viper/pull/1715

niklastreml commented 8 months ago

added some defaults, that do nothing