search

caas-team / sparrow

A monitoring tool to gather infrastructure network information
Apache License 2.0
6 stars 4 forks source link

Bug: Viper BindStruct hidden behind feature flag in viper >=v1.18.0 #78

Closed niklastreml closed 3 months ago

niklastreml commented 8 months ago

Is there an existing issue for this?

Current Behavior

We need to be careful when updating viper beyond v1.18.0

https://github.com/caas-team/sparrow/pull/73#issuecomment-1898997271

We should write a test case that checks whether marshalling from env variables works properly everywhere, so that we notice when someone updates the library and breaks it.

Expected Behavior

To fix this, we need to update our build and test pipelines to include the feature flag -tags=viper_bind_struct

Steps To Reproduce

No response

Relevant logs and/or screenshots, environment information, etc.

No response

Who can address the issue?

Anyone

Anything else?

No response

lvlcn-t commented 3 months ago

The build constraint can be removed as soon as https://github.com/spf13/viper/pull/1854 made it into a new release.