Terminate cabal-core & swarm on _destroy

cabal-club / cabal-client

interface for writing peer-to-peer chat clients

GNU General Public License v3.0

97 stars 14 forks source link

Terminate cabal-core & swarm on _destroy #12

Closed cblgh closed 4 years ago

cblgh commented 5 years ago

Are the cabal-core and the swarm also being terminated? Otherwise it'll continue peering and indexing.

(If this is non-trivial, we can make an issue & a future PR!)

_Originally posted by @noffle in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3Mjc2Mjg4OTYz/pull_request_reviews/more_threads_

cblgh commented 5 years ago

places it needs to be fixed (sorry for the screenshots, couldn't really link it handily from the pr while maintaining context)

cblgh commented 4 years ago

probably works

nikolaiwarner commented 4 years ago

@cblgh in Desktop, when a cabal was removed from the client and then added back in the same session, it'd crash because the db or swarm or something are still open.

Desktop calls client.removeCabal here: https://github.com/cabal-club/cabal-desktop/blob/ada966773b422b8acfb2242885fd08a8869cfac6/app/actions.js#L89

cblgh commented 4 years ago

o dang

hackergrrl commented 4 years ago

We fixed this!