cabal-club / cabal-client

interface for writing peer-to-peer chat clients
GNU General Public License v3.0
95 stars 14 forks source link

adds /ban, /unban, /baninfo, /banlist, /role, /mod, and /admin commands #38

Closed ghost closed 4 years ago

ghost commented 4 years ago

depends on https://github.com/cabal-club/cabal-core/pull/80

I've tested some scenarios on a local cabal (but not all). I was able to add an admin, see their ban (with /banlist) and see the ban disappear with /unban.

cblgh commented 4 years ago

@substack do you have anything against swapping out /ban, /unban etc for /hide /unhide (or /show)? as per

it shouldn't change anything while still keeping the semantics intact as we add /block, /mute etc

ghost commented 4 years ago

These can be changed to whatever. The bans aren't even used yet in the moderation views, I was just going off of how the other PR added cabal.ban(). We could also add the other methods that the draft command guide uses, this was mostly to flesh out how those would all be implemented.

cblgh commented 4 years ago

yeah that's what i thought, just figured one easy win would be to use /hide since that's the effect of a ban atm

also the prs are ofc AMAZING <3

ghost commented 4 years ago

closing this as #39 takes in these changes and adds more