search

cabal-club / cabal-client

interface for writing peer-to-peer chat clients
GNU General Public License v3.0
95 stars 14 forks source link

New messages don't trigger `new-message` event #78

Open timgoeller opened 2 years ago

timgoeller commented 2 years ago

Haven't had the time yet to really check why this happens, but it seems to be caused by this commit: 1dbd5227923aa9063b93b57cfa9dbed31e246dda (everything works when I revert these changes locally)

If I join a cabal I will receive all historical messages, but not any of the new messages (or at least the event won't be triggered for new messages). This happens even when I join these channels after I've joined the cabal.

cblgh commented 2 years ago

thanks for the issue, tim! I'll have to dive back into this again at some point it seems :)

the commit linked was basically trying to figure out an issue in cabal-desktop, where messages would get duplicated now and then or sth like that

cblgh commented 2 years ago

@timgoeller where are you seeing the issues btw, in one of your cabal-bot repos?

timgoeller commented 2 years ago

Yeah, exactly, I've tried to upgrade the bridge/cabal-bot-core to the latest client version. I'll try to do some more testing in the next days.

cblgh commented 2 years ago

lmk how i can help @timgoeller! it'd be a great way for me to ease into dev again tbh :~

cblgh commented 2 years ago

@timgoeller reverted the commit you identified (as seen above), thanks for filing an issue so it wasn't forgotten!