search

cabal-club / cabal-client

interface for writing peer-to-peer chat clients
GNU General Public License v3.0
97 stars 14 forks source link

Handles case of being unable to resolve a key. #94

Closed hackergrrl closed 2 years ago

hackergrrl commented 2 years ago

The addCabal function wasn't previously propagating name resolution errors, causing cabal-cli to crash when invoked with a bad cabal name, like cabal ewoijffwejlkw.

hackergrrl commented 2 years ago

Is anyone interested in reviewing? If not, I'll merge within the next week. 👍🏻

cblgh commented 2 years ago

i was kinda waiting to know which one was the one to merge as #95 is still open and appeared roughly at the same time X)

has this been used/verified to work against cabal-cli? if so, lgtm

hackergrrl commented 2 years ago

i was kinda waiting to know which one was the one to merge as https://github.com/cabal-club/cabal-client/pull/95 is still open and appeared roughly at the same time X)

From the public cabal: 16:03:20 <rtn> kira: yeah sorry, I complete missed yours, so we can scrap mine :)

has this been used/verified to work against cabal-cli? if so, lgtm

It has! Thanks.