search

cabal-club / cabal-desktop

Desktop client for Cabal, the p2p/decentralized/local-first chat platform.
https://cabal.chat
GNU Affero General Public License v3.0
843 stars 77 forks source link

Add link tooltip #296

Closed sylvainDNS closed 3 years ago

sylvainDNS commented 3 years ago

I made a little PR to resolve #295

I was inspired by a famous app to style it!

It's the first time that I use React portal, feel free to give a review :wink:

cblgh commented 3 years ago

thanks @sylvainDNS! would you mind including a screenshot of how it looks? helps a lot with managing visual-style PRs :)

khubo commented 3 years ago

@sylvainDNS Thanks for the PR!! I am confused about the need for portals though.

sylvainDNS commented 3 years ago

Hi! Here is the final render image

I will try to manage it without portals. Do yo squash commit during merge, or do you prefer that I push force on my own branch to keep a clean git history ?

khubo commented 3 years ago

@sylvainDNS cool, that would be lovely! Regarding the commits, you can squash them if you want to.

sylvainDNS commented 3 years ago

It's ok for me. There may be a better way to position the tooltip (with CSS only), but I didn't succeed.

khubo commented 3 years ago

@sylvainDNS i have pulled the PR and tested locally, the positioning seems fine to me :+1:

cblgh commented 3 years ago

@khubo let's merge whenever you say it's good :)

thanks again for this @sylvainDNS!